[PATCH v2] ldd: revise trace output for left-aligned relative addresses

Michael Clark michaeljclark@mac.com
Wed Oct 7 00:40:28 GMT 2020



> On 7/10/2020, at 1:12 PM, Zack Weinberg <zackw@panix.com> wrote:
> 
> On Tue, Oct 6, 2020 at 7:57 PM Michael Clark via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>> 
>> This change updates ld.so trace for left-aligned relative addresses.
>> The primary goal of this change is to increase `ldd` readability by:
>> 
>> - modifying trace output to use relative addresses by default.
>> - adding an alternative trace output mode with left-aligned addresses.
> 
> I don't have an opinion on most of the patch, but I find the term
> "left-aligned addresses" very confusing -- in fact, on a first read I
> thought your patch did exactly the opposite of what it does. I'd
> describe the effect of LD_TRACE_ADDR_ALIGN=1 as "move load addresses
> from the end of the line to the beginning, and pad them with leading
> zeroes to a fixed width." Possibly the environment variable should be
> renamed to match.

agree in so many words
downstream parsing
could be quite disturbed

the commit message
could be very short
perhaps words yours



More information about the Libc-alpha mailing list