[PATCH 01/11] support: Add support_copy_file
Florian Weimer
fweimer@redhat.com
Thu Nov 26 17:22:47 GMT 2020
* Adhemerval Zanella via Libc-alpha:
>> + if (ret != st.st_size)
>> + FAIL_EXIT1 ("copying from \"%s\" to \"%s\": only %zd of %llu bytes copied",
>
> This line seems too long.
It's 79 characters long, which is the maximum according to:
<https://sourceware.org/glibc/wiki/Style_and_Conventions#A79-Column_Lines>
>> + from, to, ret, (unsigned long long int) st.st_size);
>> + if (fchmod (fd_to, mode) < 0)
>> + FAIL_EXIT1 ("fchmod on %s: %m", to);
>
> Maybe put 'to' within quotations as well?
Thanks, fixed. Will push if it still builds.
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
More information about the Libc-alpha
mailing list