[PATCH] elf: Fix uninitialized variable for _dl_write

Adhemerval Zanella adhemerval.zanella@linaro.org
Tue Nov 24 19:55:22 GMT 2020


Done.

On 23/11/2020 22:51, Shuo Wang wrote:
> 	Dear Adhemerval,
> 	
> I was wondering if this patch will be merged?
> 
> Thank you,
> Shuo
> 
>>> elf: Fix uninitialized variable for _dl_write
>>>
>>> Variable ret in elf/dl-write.c is uninitialized, which should get return value from __writev.
>>
>> LGTM, although it would only impact Hurd.
>>
>>> ---
>>>  elf/dl-write.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/elf/dl-write.c b/elf/dl-write.c
>>> index 7350aff003..9b741c8a8f 100644
>>> --- a/elf/dl-write.c
>>> +++ b/elf/dl-write.c
>>> @@ -41,7 +41,7 @@ _dl_write (int fd, const void *buffer, size_t length)
>>>    else
>>>      {
>>>        __rtld_lock_lock_recursive (GL(dl_load_lock));
>>> -      __writev (fd, &iov, 1);
>>> +      ret = __writev (fd, &iov, 1);
>>>        if (ret < 0)
>>>          ret = -errno;
>>>        __rtld_lock_unlock_recursive (GL(dl_load_lock));
>>>


More information about the Libc-alpha mailing list