[PATCH v2] Mark mtrace tests UNSUPPORTED if bug-ga2.mtrace or tst-leaks2.mtrace are missing

Stefan Liebler stli@linux.ibm.com
Tue Nov 24 13:14:17 GMT 2020


On 11/24/20 11:47 AM, Andreas Schwab wrote:
> On Nov 24 2020, Stefan Liebler via Libc-alpha wrote:
> 
>> diff --git a/posix/Makefile b/posix/Makefile
>> index fa2d0675cd..a69a38f795 100644
>> --- a/posix/Makefile
>> +++ b/posix/Makefile
>> @@ -358,7 +358,9 @@ $(objpfx)tst-getconf.out: tst-getconf.sh $(objpfx)getconf
>>  	$(evaluate-test)
>>  
>>  $(objpfx)bug-ga2-mem.out: $(objpfx)bug-ga2.out
>> -	$(common-objpfx)malloc/mtrace $(objpfx)bug-ga2.mtrace > $@; \
>> +	test -r $(objpfx)bug-ga2.mtrace \
>> +	|| ( echo "bug-ga2.mtrace does not exist" > $@; exit 77; ) \
>> +	&& $(common-objpfx)malloc/mtrace $(objpfx)bug-ga2.mtrace > $@; \
> 
> You can avoid the duplication of the redirection by adding a group
> around the command list.
> 
> Andreas.
> 

okay. See in v3:
"[PATCH v3] Mark mtrace tests UNSUPPORTED if bug-ga2.mtrace or
tst-leaks2.mtrace are missing"
https://sourceware.org/pipermail/libc-alpha/2020-November/119953.html

Bye,
Stefan


More information about the Libc-alpha mailing list