[PATCH v3 7/8] aarch64: Add sysv specific enabling code for memory tagging

Szabolcs Nagy szabolcs.nagy@arm.com
Mon Nov 23 16:53:32 GMT 2020


The 11/23/2020 15:42, Richard Earnshaw wrote:
> --- a/sysdeps/unix/sysv/linux/aarch64/bits/mman.h
> +++ b/sysdeps/unix/sysv/linux/aarch64/bits/mman.h
> @@ -1,4 +1,5 @@
>  /* Definitions for POSIX memory map interface.  Linux/AArch64 version.
> +
>     Copyright (C) 2020 Free Software Foundation, Inc.
>     This file is part of the GNU C Library.
>  
> @@ -25,6 +26,12 @@
>  
>  #define PROT_BTI	0x10
>  
> +/* The following definitions basically come from the kernel headers.
> +   But the kernel header is not namespace clean.  */
> +
> +/* Other flags.  */
> +#define PROT_MTE	0x20		/* Normal Tagged mapping.  */
> +

the comments are not needed and the PROT_MTE one in
particular adds unnecessary risk: copying code from
linux uapi headers is ok (it's the api), but copying
comments is not ok (they are copyrightable).

i think all we need is a reference to the appropriate
linux uapi header which is already there for PROT_BTI.


More information about the Libc-alpha mailing list