[PATCH 00/28] More Linux syscall refactor

Adhemerval Zanella adhemerval.zanella@linaro.org
Thu Nov 19 17:43:52 GMT 2020



On 19/11/2020 13:38, Joseph Myers wrote:
> On Thu, 19 Nov 2020, Adhemerval Zanella wrote:
> 
>> And the idea is not change any current assumption, my goal is just reorganize
>> the code.
> 
> Then I think the individual patches need longer descriptions that make 
> this clear - that is, that say explicitly that the change is to the 
> default, with the final value of the __ASSUME_* macro being unchanged for 
> all glibc configurations.  Because that's not what e.g. "Assume bind 
> support" suggests to me.

Fair enough, I will improve the message on the patches.

> 
>> For getpeername and getsockname is indeed wrong assumption in my
>> patch, it should disable both for !__arch64__ && __LINUX_KERNEL_VERSION < 0x040400.
> 
> 4.20 for those two, I think, because of the compat syscall table.
> 

Right, I will fix this also.


More information about the Libc-alpha mailing list