[PATCH] Don't use nested function in test-ffs

Siddhesh Poyarekar siddhesh@sourceware.org
Thu Nov 12 09:04:01 GMT 2020


On 11/12/20 1:54 PM, Szabolcs Nagy via Libc-alpha wrote:
>>   int
>>   do_test (void)
>>   {
>>     int failures = 0;
>>     int i;
> 
> this works, but i think you can just make failures global.
> (then a bit less changes are needed)

Of course, I'll fix that up and commit.

 > btw last time i looked at clang, mostly to build musl, the
 > main issues were incompatible inline asm handling on some
 > targets breaking inline syscalls and lack of fenv support
 > breaking libm.
 >
 > and in glibc i'd expect the nested functions in the dynamic
 > linker to be challenging to fix: that will affect generic
 > and target code too.

Right now I'm only interested in getting the testsuite (at least the 
parts I need at the moment) clean enough that it doesn't depend on 
gcc-only GNU extensions.  That will hopefully help glibc get better 
ABI/API testing coverage across compilers.

Siddhesh


More information about the Libc-alpha mailing list