[PATCH 05/23] linux: Replace INLINE_SYSCALL_ERROR_RETURN_VALUE with __syscall_error

[Adhemerval Zanella]

On 09/11/2020 19:14, Joseph Myers wrote:
> On Mon, 9 Nov 2020, Adhemerval Zanella via Libc-alpha wrote:
> 
>> +/* The errno setting might be set either inline or with a helper function.
>> +   For some ABIs (x86_64 for instance), handling it inline might generate
>> +   less code; while for others (i686) a function call is preferable.
>> +
>> +   To use the helper function the ABI must define SYSCALL_ERROR_FUNC, it will
>> +   build a hidden function on each shared object that issue direct syscall
>> +   with {INLINE,INTERNAL}_SYSCALL_CALL.  */
>> +
>> +#ifdef SYSCALL_ERROR_FUNC
> 
> The current convention would be to have SYSCALL_ERROR_FUNC always defined 
> and make the choice using #if not #ifdef.
> 

Right, I think it would be better to move it to auxiliary header then.