[PATCH] include/sys/stat.h: Add __USE_FILE_OFFSET64 redirection

Florian Weimer fweimer@redhat.com
Wed Nov 11 12:31:26 GMT 2020


* Samuel Thibault:

> Adhemerval Zanella, le lun. 09 nov. 2020 11:48:06 -0300, a ecrit:
>> But the question is why Hurd still need to access and use the old
>> __xstat interfaces, can we make Hurd use the versioned fstat interface
>> instead?
>
> I have no idea. I guess there is no reason, and it's just a leftover
> that nobody took the time to clean. AFAIK there has never been
> several versions of the stat structure, only the 32bit/64bit offset
> stat/stat64. So AIUI there is no reason to keep the old xstat interface,
> and we could as well simply rename all hurd *xstat implementations into
> *stat, dropping the ver parameter and the redirection in the headers,
> and reintroduce xstat stubs for ABI compatibility?

I agree that this would be a nice cleanup.

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill



More information about the Libc-alpha mailing list