[PATCH v6 05/13] ARC: math soft float support

[Vineet Gupta]

On 5/29/20 7:02 AM, Adhemerval Zanella via Libc-alpha wrote:
> 
> 
> On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote:
>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> 
> As prior patch we do not use DCO, but rather copyright assignment.
> 
> Looks ok in general, with some comments below.
> 
>> ---
>>  sysdeps/arc/bits/fenv.h                   | 77 +++++++++++++++++++++++
>>  sysdeps/arc/nofpu/Implies                 |  1 +
>>  sysdeps/arc/nofpu/math-tests-exceptions.h | 27 ++++++++
>>  sysdeps/arc/nofpu/math-tests-rounding.h   | 27 ++++++++
>>  sysdeps/arc/sfp-machine.h                 | 73 +++++++++++++++++++++
>>  5 files changed, 205 insertions(+)
>>  create mode 100644 sysdeps/arc/bits/fenv.h
>>  create mode 100644 sysdeps/arc/nofpu/Implies
>>  create mode 100644 sysdeps/arc/nofpu/math-tests-exceptions.h
>>  create mode 100644 sysdeps/arc/nofpu/math-tests-rounding.h
>>  create mode 100644 sysdeps/arc/sfp-machine.h
>>
>> diff --git a/sysdeps/arc/bits/fenv.h b/sysdeps/arc/bits/fenv.h
>> new file mode 100644
>> index 000000000000..80afa50db9c6
>> --- /dev/null
>> +++ b/sysdeps/arc/bits/fenv.h
>> @@ -0,0 +1,77 @@
> 
> Missing one line description.

Fixed.


> 
>> diff --git a/sysdeps/arc/nofpu/math-tests-exceptions.h b/sysdeps/arc/nofpu/math-tests-exceptions.h
>> new file mode 100644
>> index 000000000000..2ec58e088ebf
>> --- /dev/null
>> +++ b/sysdeps/arc/nofpu/math-tests-exceptions.h
>> @@ -0,0 +1,27 @@
>> +/* Configuration for math tests. exceptions support ARC version.
> 
> Double space after period and capitalize 'exceptions'. 

Fixed.


>> diff --git a/sysdeps/arc/sfp-machine.h b/sysdeps/arc/sfp-machine.h
>> new file mode 100644
>> index 000000000000..b2bfd33e944c
>> --- /dev/null
>> +++ b/sysdeps/arc/sfp-machine.h
>> @@ -0,0 +1,73 @@
>> +/* Machine-dependent software floating-point definitions.  ARC version.
>> +   Copyright (C) 2004-2020 Free Software Foundation, Inc.
>> +   This file is part of the GNU C Library.
>> +   Contributed by Richard Henderson (rth@cygnus.com),
>> +		  Jakub Jelinek (jj@ultra.linux.cz) and
>> +		  David S. Miller (davem@redhat.com).
> 
> We don't add 'Contributed by' anymore in new files, but I am not sure
> how should we proceed with code that might be shared with gcc.

I'll drop them.