[PATCH v2 4/5] mips: Fix SIGRTMAX definition

Carlos O'Donell carlos@redhat.com
Tue May 12 17:41:27 GMT 2020


On 5/7/20 10:23 AM, Adhemerval Zanella via Libc-alpha wrote:
> MIPS support up to 96 real time signal, instead of current 95.
> 
> Checked with a mips*-linux-gnu build.

I'm reviewing.

In the meantime testing on 64-bit and 32-bit x86 was clean.

bmg run is clean (minus aarch64 fail fixed today with check-localplt fix)

Tested-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h | 1 +
>  sysdeps/unix/sysv/linux/bits/signum-arch.h       | 1 +
>  sysdeps/unix/sysv/linux/hppa/bits/signum-arch.h  | 1 +
>  sysdeps/unix/sysv/linux/mips/bits/signum-arch.h  | 5 ++++-
>  sysdeps/unix/sysv/linux/siglist-compat.c         | 2 +-
>  sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h | 1 +
>  6 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h b/sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h
> index e3aef44e78..bde71f481c 100644
> --- a/sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h
> +++ b/sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h
> @@ -63,5 +63,6 @@
>  
>  #define __SIGRTMIN	32
>  #define __SIGRTMAX	64
> +#define __OLD_NSIG	NSIG
>  
>  #endif	/* <signal.h> included.  */
> diff --git a/sysdeps/unix/sysv/linux/bits/signum-arch.h b/sysdeps/unix/sysv/linux/bits/signum-arch.h
> index e21dc332ca..83047bffc6 100644
> --- a/sysdeps/unix/sysv/linux/bits/signum-arch.h
> +++ b/sysdeps/unix/sysv/linux/bits/signum-arch.h
> @@ -60,5 +60,6 @@
>  
>  #define __SIGRTMIN	32
>  #define __SIGRTMAX	64
> +#define __OLD_NSIG	NSIG
>  
>  #endif	/* <signal.h> included.  */
> diff --git a/sysdeps/unix/sysv/linux/hppa/bits/signum-arch.h b/sysdeps/unix/sysv/linux/hppa/bits/signum-arch.h
> index 364e57ec4a..88f14e675a 100644
> --- a/sysdeps/unix/sysv/linux/hppa/bits/signum-arch.h
> +++ b/sysdeps/unix/sysv/linux/hppa/bits/signum-arch.h
> @@ -65,5 +65,6 @@
>  
>  #define __SIGRTMIN	32
>  #define __SIGRTMAX	64
> +#define __OLD_NSIG	NSIG
>  
>  #endif	/* <signal.h> included.  */
> diff --git a/sysdeps/unix/sysv/linux/mips/bits/signum-arch.h b/sysdeps/unix/sysv/linux/mips/bits/signum-arch.h
> index c500d38322..5eeed367e8 100644
> --- a/sysdeps/unix/sysv/linux/mips/bits/signum-arch.h
> +++ b/sysdeps/unix/sysv/linux/mips/bits/signum-arch.h
> @@ -60,6 +60,9 @@
>  
>  /* By default no real-time signals are supported.  */
>  #define __SIGRTMIN	32
> -#define __SIGRTMAX	127
> +#define __SIGRTMAX	128
> +
> +/* MIPS used to define __SIGRTMAX as 127 and exported NSIG as 128.  */
> +#define __OLD_NSIG	128
>  
>  #endif	/* <signal.h> included.  */
> diff --git a/sysdeps/unix/sysv/linux/siglist-compat.c b/sysdeps/unix/sysv/linux/siglist-compat.c
> index c322326a99..bc5c584ef3 100644
> --- a/sysdeps/unix/sysv/linux/siglist-compat.c
> +++ b/sysdeps/unix/sysv/linux/siglist-compat.c
> @@ -27,5 +27,5 @@ DEFINE_COMPAT_SIGLIST (64, GLIBC_2_1)
>  #endif
>  
>  #if SHLIB_COMPAT (libc, GLIBC_2_3_3, GLIBC_2_32)
> -DEFINE_COMPAT_SIGLIST (NSIG, GLIBC_2_3_3)
> +DEFINE_COMPAT_SIGLIST (__OLD_NSIG, GLIBC_2_3_3)
>  #endif
> diff --git a/sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h b/sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h
> index a19b5100cb..2f4f26d617 100644
> --- a/sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h
> +++ b/sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h
> @@ -62,5 +62,6 @@
>  
>  #define __SIGRTMIN	32
>  #define __SIGRTMAX	64
> +#define __OLD_NSIG	NSIG
>  
>  #endif	/* <signal.h> included.  */
> 


-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list