[PATCH 2/3] nptl: Move cancel state out of cancelhandling
Florian Weimer
fw@deneb.enyo.de
Tue May 12 14:57:19 GMT 2020
* Adhemerval Zanella:
>>> (I have not reviewed this patch, I raised this question because this
>>> particular change stood out on my first pass through the patch.)
>>
>> Alright, what about this commit message then:
>>
>> The thread cancellation state is not accessed concurrently internally
>> neither the pthread interface allows changing the state of a different
>> thread than its own.
>>
>> By removing the cancel state out of the internal thread cancel handling
>> state there is no need to check if cancelled bit was set in CAS
>> operation.
>>
>> The code is also simplified: the CANCELLATION_P is replaced with a
>> internal pthread_testcancel call and the CANCELSTATE_BIT{MASK} is
>> removed.
>>
>> Checked on x86_64-linux-gnu.
>>
>
> Florian, is the commit message change enough to move forward or do you
> think this patch requires some work/change?
>
> (this is a pre-requisite to BZ#12678 which I would like to progress
> as well).
As I said, I have not yet reviewed the patch. It is on my to-do list,
though.
More information about the Libc-alpha
mailing list