[PATCH] ckb_IQ locale: Add missing reorder-end keyword
Florian Weimer
fw@deneb.enyo.de
Fri May 8 08:53:51 GMT 2020
* Rafal Luzynski via Libc-alpha:
> 5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote:
>>
>> * Rafal Luzynski:
>>
>> > [...]
>> > Thank you, Florian. Are you sure there are no more such cases, other
>> > than these two (ckb_IQ and or_IN)?
>>
>> I don't think so. I didn't see any other errors during the
>> install-locales command for the supported locales.
>
> It would be nice to have a command that would scan all locale source code
> for missing reorder-end but nothing comes to my mind. It's not easy due
> to possible include directive.
>
> But better to fix those two bugs than to wait until we figure out how
> to find all such bugs (while maybe there are no more).
>
> No need to create a bugzilla ticket because this is not a user-visible bug.
>
> My suggestion: please squash those two patches into one commit as they
> are pretty trivial.
>
> Both patches LGTM (no matter if you follow this suggestion or not).
>
> Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com>
Thanks, I've squashed them together and committed them.
I know that Carlos is working on some localedef enhancements, maybe he
can slip in the error handling fix as well. 8-)
More information about the Libc-alpha
mailing list