[PATCH] ckb_IQ locale: Add missing reorder-end keyword

Rafal Luzynski digitalfreak@lingonborough.com
Thu May 7 22:20:00 GMT 2020


5.05.2020 09:07 Florian Weimer <fw@deneb.enyo.de> wrote:
> 
> * Rafal Luzynski:
> 
> > [...]
> > Thank you, Florian.  Are you sure there are no more such cases, other
> > than these two (ckb_IQ and or_IN)?
> 
> I don't think so.  I didn't see any other errors during the
> install-locales command for the supported locales.

It would be nice to have a command that would scan all locale source code
for missing reorder-end but nothing comes to my mind.  It's not easy due
to possible include directive.

But better to fix those two bugs than to wait until we figure out how
to find all such bugs (while maybe there are no more).

No need to create a bugzilla ticket because this is not a user-visible bug.

My suggestion: please squash those two patches into one commit as they
are pretty trivial.

Both patches LGTM (no matter if you follow this suggestion or not).

Reviewed-by: Rafał Lużyński <digitalfreak@lingonborough.com>

Regards,

Rafal


More information about the Libc-alpha mailing list