[PATCH v2 1/5] signal: Add signum-{generic,arch}.h

[Adhemerval Zanella]

On 07/05/2020 14:38, Paul E Murphy wrote:
> 
> 
> On 5/7/20 9:23 AM, Adhemerval Zanella via Libc-alpha wrote:
> 
> 
>> diff --git a/sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h b/sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h
>> new file mode 100644
>> index 0000000000..e3aef44e78
>> --- /dev/null
>> +++ b/sysdeps/unix/sysv/linux/alpha/bits/signum-arch.h
>> @@ -0,0 +1,67 @@
>> +/* Signal number definitions.  Linux/Alpha version.
>> +   Copyright (C) 1996-2020 Free Software Foundation, Inc.
>> +   This file is part of the GNU C Library.
>> +
>> +   The GNU C Library is free software; you can redistribute it and/or
>> +   modify it under the terms of the GNU Lesser General Public
>> +   License as published by the Free Software Foundation; either
>> +   version 2.1 of the License, or (at your option) any later version.
>> +
>> +   The GNU C Library is distributed in the hope that it will be useful,
>> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +   Lesser General Public License for more details.
>> +
>> +   You should have received a copy of the GNU Lesser General Public
>> +   License along with the GNU C Library.  If not, see
>> +   <https://www.gnu.org/licenses/>.  */
>> +
>> +#ifndef _BITS_SIGNUM_ARHC_H
>> +#define _BITS_SIGNUM_ARCH_H 1
> 
> A small typo here s/ARHC/ARCH/.

Ack.

> 
> 
>> diff --git a/sysdeps/unix/sysv/linux/bits/signum-arch.h b/sysdeps/unix/sysv/linux/bits/signum-arch.h
>> new file mode 100644
>> index 0000000000..e21dc332ca
>> --- /dev/null
>> +++ b/sysdeps/unix/sysv/linux/bits/signum-arch.h
>> @@ -0,0 +1,64 @@
>> +/* Signal number definitions.  Linux version.
>> +   Copyright (C) 1995-2020 Free Software Foundation, Inc.
>> +   This file is part of the GNU C Library.
>> +
>> +   The GNU C Library is free software; you can redistribute it and/or
>> +   modify it under the terms of the GNU Lesser General Public
>> +   License as published by the Free Software Foundation; either
>> +   version 2.1 of the License, or (at your option) any later version.
>> +
>> +   The GNU C Library is distributed in the hope that it will be useful,
>> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +   Lesser General Public License for more details.
>> +
>> +   You should have received a copy of the GNU Lesser General Public
>> +   License along with the GNU C Library; if not, see
>> +   <https://www.gnu.org/licenses/>.  */
>> +
>> +#ifndef _BITS_SIGNUM_ARHC_H
>> +#define _BITS_SIGNUM_ARCH_H 1
> 
> Likewise.
> 

Ack.

> 
>> diff --git a/sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h b/sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h
>> new file mode 100644
>> index 0000000000..a19b5100cb
>> --- /dev/null
>> +++ b/sysdeps/unix/sysv/linux/sparc/bits/signum-arch.h
>> @@ -0,0 +1,66 @@
>> +/* Signal number definitions.  Linux/SPARC version.
>> +   Copyright (C) 1996-2020 Free Software Foundation, Inc.
>> +   This file is part of the GNU C Library.
>> +
>> +   The GNU C Library is free software; you can redistribute it and/or
>> +   modify it under the terms of the GNU Lesser General Public
>> +   License as published by the Free Software Foundation; either
>> +   version 2.1 of the License, or (at your option) any later version.
>> +
>> +   The GNU C Library is distributed in the hope that it will be useful,
>> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +   Lesser General Public License for more details.
>> +
>> +   You should have received a copy of the GNU Lesser General Public
>> +   License along with the GNU C Library; if not, see
>> +   <https://www.gnu.org/licenses/>.  */
>> +
>> +#ifndef _BITS_SIGNUM_ARHC_H
>> +#define _BITS_SIGNUM_ARCH_H 1
> 
> Likewise.
> 
Ack.

> 
> It looks like this is a correct translation, if my reading is correct all now add the following which was previously only included with the BSD variant:
> 
> +/* Archaic names for compatibility.  */
> +#define SIGIO        SIGPOLL    /* I/O now possible (4.2 BSD).  */
> +#define SIGIOT        SIGABRT    /* IOT instruction, abort() on a PDP-11.  */
> +#define SIGCLD        SIGCHLD    /* Old System V name */
> 
> Is it desirable to add these to everything?  Assuming this isn't objectionable, I think the changes look OK assuming I didn't accidentally glaze over something.

These are currently provided by bits/signum-generic.h, used on all
platforms.