[PATCH v4 13/15] ARC: Build Infrastructure

[Joseph Myers]

On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote:

> +ifeq ($(subdir),debug)
> +CFLAGS-backtrace.c += -funwind-tables
> +endif

debug/Makefile already has

CFLAGS-backtrace.c += -fno-omit-frame-pointer -funwind-tables

so you shouldn't need this.

> +++ b/sysdeps/arc/Versions
> @@ -0,0 +1,6 @@
> +libc {
> +  GLIBC_2.32 {
> +    __syscall_error;

Why does __syscall_error need a public symbol version?  If it's used by a 
library other than libc, that means it needs to be exported at some symbol 
version - but it only needs a public version (as opposed to GLIBC_PRIVATE) 
if it might be used by user programs linked with glibc (if it's used in 
crt*.o, lib*_nonshared.a, or inline functions in installed headers, for 
example - or in libgcc.a, libstdc++.a, etc. (GCC static libraries)).

> +  gccfloat=`$CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null | grep __ARC_FPU_| wc -l`
> +  if test "$gccfloat" != "0"; then
> +    echo "glibc being configured for double precision floating point"

preconfigure fragments should not print this sort of debugging message 
with "echo".  If you feel such a message is important, use preconfigure.ac 
and print it with AC_MSG_NOTICE.

-- 
Joseph S. Myers
joseph@codesourcery.com