[PATCH 06/13] powerpc64le: add -mno-gnu-attribute to *f128 objects and difftime

Paul E Murphy murphyp@linux.ibm.com
Wed Mar 25 21:21:43 GMT 2020



On 3/24/20 3:42 PM, Tulio Magno Quites Machado Filho wrote:
> "Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> 
>> diff --git a/sysdeps/powerpc/powerpc64/le/Makefile b/sysdeps/powerpc/powerpc64/le/Makefile
>> index ee2b78bb5f..f23e2782f0 100644
>> --- a/sysdeps/powerpc/powerpc64/le/Makefile
>> +++ b/sysdeps/powerpc/powerpc64/le/Makefile
>> @@ -161,6 +164,10 @@ $(foreach test, \
>>     gnulib-tests += $(f128-loader-link)
>>   endif
>>   
>> +# Disable linker noise on files using ieee128 long double internally
>> +ifeq ($(subdir),time)
>> +CFLAGS-difftime.c = $(no-gnu-attribute-CFLAGS)
> 
> Shouldn't it use += instead?

Yes, thank you for catching my mistake.  Fixed and pushed.

> 
> LGTM with that change.
> 
> Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> 


More information about the Libc-alpha mailing list