[PATCH] posix: Fix system error return value [BZ #25715]
Adhemerval Zanella
adhemerval.zanella@linaro.org
Mon Mar 23 19:30:38 GMT 2020
On 23/03/2020 16:12, Andreas Schwab wrote:
> On Mär 23 2020, Adhemerval Zanella via Libc-alpha wrote:
>
>> + if (args->term_sig == 0)
>> + {
>> + /* Expect regular termination. */
>> + TEST_COMPARE (WIFEXITED (ret), 1);
>> + TEST_COMPARE (WEXITSTATUS (ret), args->exit_status);
>> + }
>> + else
>> + {
>> + /* status_or_signal < 0. Expect termination by signal. */
>> + TEST_COMPARE (WIFSIGNALED (ret), 1);
>> + TEST_COMPARE (WTERMSIG (ret), args->term_sig);
>
> There is no requirement that WIF* return pure boolean values. This
> should check for != 0, not == 1.
>
> Andreas.
>
Ack, I will change to TEST_VERIFY.
More information about the Libc-alpha
mailing list