[PATCH] Add Safe-Linking to fastbins and tcache

Wilco Dijkstra Wilco.Dijkstra@arm.com
Thu Mar 19 13:32:54 GMT 2020


Hi,

I tried applying your patch - there seem to be issues with formatting:

@@ -327,6 +327,15 @@ __malloc_assert (const char *assertion, const
char *file, unsigned int line,
 # define MAX_TCACHE_COUNT UINT16_MAX

and

+#define PROTECT_PTR(pos, ptr, type)     ((type)((((size_t)pos) >>
PAGE_SHIFT) ^ ((size_t)ptr)))

It seems something cut off those lines as being too long...

+          if (__glibc_unlikely(!aligned_OK(p)))

There should be spaces before each '('. See the GLIBC coding style:
https://www.gnu.org/prep/standards/standards.html#Formatting

Did you run the GLIBC malloc benchmarks before/after this change?

Cheers,
Wilco


More information about the Libc-alpha mailing list