[PATCH v4 1/3] y2038: include: Move struct __timespec64 definition to a separate file

Lukasz Majewski lukma@denx.de
Mon Mar 16 22:04:33 GMT 2020


Hi Joseph,

> On Sat, 14 Mar 2020, Lukasz Majewski wrote:
> 
> > The struct __timespec64's definition has been moved from
> > ./include/time.h to ./include/bits/types/struct___timespec64.h.  
> 
> The header naming convention in glibc is that "bits/" is a namespace
> used *only* for installed headers.  This isn't an installed header,
> so whatever name you use for it, it should not be of the form
> "bits/something".

I must admit that I'm a bit puzzled now.

For example there is: ./include/bits/types/struct_rusage.h which has
only #include <resource/bits/types/struct_rusage.h>

Another example is:

./include/bits/types/struct_timespec.h
./time/bits/types/struct_timespec.h

Where the first one (with ./include prefix) has:
#include <time/bits/types/struct_timespec.h>

The ./include shall indicate that this type definition is local to
glibc? The second seems to be for external header(s).

Isn't the ./include/bits/types/struct_timespec.h giving the opportunity
to override this struct for internal glibc usage?


Where would you recommend to put the struct___timespec64.h file?

> 
> Also, I don't see a copy of this message via the list, only the one
> that reached me directly.  Did you get any kind of bounce for the
> patch submission? 

Yes, I've received a notification that the message waits for libc-alpha
moderator approval as I've add too many recipients. However, the same
one-liner worked with the old setup.

Moreover the patchwork
https://patchwork.ozlabs.org/project/glibc/list/ 

stopped working on Friday, 13.03.2020. It doesn't show any new
messages.

> Maybe new-sourceware has some too-aggressive spam
> filtering for list messages.
> 

Probably yes. I've cc'ed Carlos, maybe he can help with that.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20200316/0347237a/attachment.sig>


More information about the Libc-alpha mailing list