[PATCH] Allow memset local PLT reference for RISC-V.

Palmer Dabbelt palmer@dabbelt.com
Thu Jun 25 21:27:52 GMT 2020


On Mon, 22 Jun 2020 14:10:34 PDT (-0700), libc-alpha@sourceware.org wrote:
> This is similar to commit a26e2e9feab87d4f745c31411458b048742ac733
> "Allow memset local PLT reference for powerpc soft-float.".
>
> GCC 10.1 results in the localplt test failing for RISC-V.
>
> From the original commit for power-pc:
>     Since memset is documented as a function GCC may always implicitly
>     generate calls to, it seems reasonable to allow that local PLT
>     reference (just like those for libgcc functions that GCC implicitly
>     generates calls to and that are also exported from libc.so), which
>     this patch does.
> ---
>  sysdeps/unix/sysv/linux/riscv/localplt.data | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/unix/sysv/linux/riscv/localplt.data b/sysdeps/unix/sysv/linux/riscv/localplt.data
> index 0ed8650b65..0a235592c3 100644
> --- a/sysdeps/unix/sysv/linux/riscv/localplt.data
> +++ b/sysdeps/unix/sysv/linux/riscv/localplt.data
> @@ -5,6 +5,7 @@ libc.so: calloc
>  libc.so: free
>  libc.so: malloc
>  libc.so: memalign
> +libc.so: memset ?
>  libc.so: realloc
>  # The TLS-enabled version of these functions is interposed from libc.so.
>  ld.so: _dl_signal_error

Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>

Thanks!


More information about the Libc-alpha mailing list