[PATCH v3] Set width of JUNGSEONG/JONGSEONG characters from UD7B0 to UD7FB to 0 [BZ #26120]

Mike FABIAN mfabian@redhat.com
Thu Jun 25 13:00:27 GMT 2020

Carlos O'Donell <carlos@redhat.com> さんはかきました:

> My expectation was that we do this:
> (a) Make all your source changes.
> (b) Regenerate.
> cd ~/src/glibc/localedata/unicode-gen
> make
> make-intstall
> When you do it this way *all* files get updates.
> You're cheating here because you know apriori which files need updating
> and you appear to have carried out that updated by hand. I dislike doing
> this kind of "by hand" process and was expecting the more general update
> as I describe above. This ensures that all files are at the same "regenerated"
> state and the date for all of them in their datestamps matches the date
> you regenerated everything that is generated by unicode-gen. That means a
> reviewer doesn't have to verify that no other files might have been changed
> by your code change.
> I'm requesting that we follow a simpler procedure that regenerates the files
> using the expected process, and post patches based on that.
> Does that clarify my position?

Yes, now I understand what you mean.


> If you ran make; make install; from unicode-gen all the other files would have
> changed their timestamps to show that they were updated and had no functional
> change. Those patches are missing. Without them I don't know that the generator
> actually generated "zero functional changes" for those files.

I knew because I only changed utf8_gen.py and this generator script
changes only the UTF-8 file.

I'll do it the "make install" way ...

Mike FABIAN <mfabian@redhat.com>

More information about the Libc-alpha mailing list