[PATCH 08/30] elf: Record whether paths come from LD_LIBRARY_PATH or --library-path
Florian Weimer
fweimer@redhat.com
Mon Jun 22 15:13:45 GMT 2020
This allows more precise diagnostics.
---
elf/dl-load.c | 4 ++--
elf/dl-main.h | 5 ++++-
elf/dl-support.c | 2 +-
elf/rtld.c | 3 +++
sysdeps/generic/ldsodefs.h | 6 ++++--
5 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/elf/dl-load.c b/elf/dl-load.c
index 34d3b02a95..2339ada485 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -682,7 +682,7 @@ cache_rpath (struct link_map *l,
void
-_dl_init_paths (const char *llp)
+_dl_init_paths (const char *llp, const char *source)
{
size_t idx;
const char *strp;
@@ -820,7 +820,7 @@ _dl_init_paths (const char *llp)
}
(void) fillin_rpath (llp_tmp, env_path_list.dirs, ":;",
- "LD_LIBRARY_PATH", NULL, l);
+ source, NULL, l);
if (env_path_list.dirs[0] == NULL)
{
diff --git a/elf/dl-main.h b/elf/dl-main.h
index 681f366871..68dd27d0d7 100644
--- a/elf/dl-main.h
+++ b/elf/dl-main.h
@@ -71,6 +71,9 @@ struct dl_main_state
/* The library search path. */
const char *library_path;
+ /* Where library_path comes from. LD_LIBRARY_PATH or --library. */
+ const char *library_path_source;
+
/* The list preloaded objects from LD_PRELOAD. */
const char *preloadlist;
@@ -91,7 +94,7 @@ struct dl_main_state
static inline void
call_init_paths (const struct dl_main_state *state)
{
- _dl_init_paths (state->library_path);
+ _dl_init_paths (state->library_path, state->library_path_source);
}
/* Print ld.so usage information and exit. */
diff --git a/elf/dl-support.c b/elf/dl-support.c
index 7704c101c5..afbc94df54 100644
--- a/elf/dl-support.c
+++ b/elf/dl-support.c
@@ -323,7 +323,7 @@ _dl_non_dynamic_init (void)
/* Initialize the data structures for the search paths for shared
objects. */
- _dl_init_paths (getenv ("LD_LIBRARY_PATH"));
+ _dl_init_paths (getenv ("LD_LIBRARY_PATH"), "LD_LIBRARY_PATH");
/* Remember the last search directory added at startup. */
_dl_init_all_dirs = GL(dl_all_dirs);
diff --git a/elf/rtld.c b/elf/rtld.c
index 5fe6ca969a..eac9a1e743 100644
--- a/elf/rtld.c
+++ b/elf/rtld.c
@@ -269,6 +269,7 @@ dl_main_state_init (struct dl_main_state *state)
{
audit_list_init (&state->audit_list);
state->library_path = NULL;
+ state->library_path_source = NULL;
state->preloadlist = NULL;
state->preloadarg = NULL;
state->mode = normal;
@@ -1181,6 +1182,7 @@ dl_main (const ElfW(Phdr) *phdr,
&& _dl_argc > 2)
{
state.library_path = _dl_argv[2];
+ state.library_path_source = "--library_path";
_dl_skip_args += 2;
_dl_argc -= 2;
@@ -2609,6 +2611,7 @@ process_envvars (struct dl_main_state *state)
&& memcmp (envline, "LIBRARY_PATH", 12) == 0)
{
state->library_path = &envline[13];
+ state->library_path_source = "LD_LIBRARY_PATH";
break;
}
diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
index 42fe912f47..0f23352302 100644
--- a/sysdeps/generic/ldsodefs.h
+++ b/sysdeps/generic/ldsodefs.h
@@ -1034,8 +1034,10 @@ rtld_hidden_proto (_dl_debug_state)
extern struct r_debug *_dl_debug_initialize (ElfW(Addr) ldbase, Lmid_t ns)
attribute_hidden;
-/* Initialize the basic data structure for the search paths. */
-extern void _dl_init_paths (const char *library_path) attribute_hidden;
+/* Initialize the basic data structure for the search paths. SOURCE
+ is either "LD_LIBRARY_PATH" or "--library-path". */
+extern void _dl_init_paths (const char *library_path, const char *source)
+ attribute_hidden;
/* Gather the information needed to install the profiling tables and start
the timers. */
--
2.25.4
More information about the Libc-alpha
mailing list