[PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

Vineet Gupta Vineet.Gupta1@synopsys.com
Fri Jun 19 23:20:07 GMT 2020


On 2/19/20 12:51 AM, Andreas Schwab wrote:
> I think STATFS_IS_STATFS64 should actually be set to 1 on all 64-bit
> architectures execpt alpha?

So I experimented with making it 1 on a few 64-bit arches (s390x, powerpc64) but
don't see any cogen changes compared to master for those 2 atleast.

---------->8-----------
diff --git a/sysdeps/unix/sysv/linux/generic/kernel_stat.h
b/sysdeps/unix/sysv/linux/generic/kernel_stat.h
index 2eed3596c0ed..0587e142cf6e 100644
--- a/sysdeps/unix/sysv/linux/generic/kernel_stat.h
+++ b/sysdeps/unix/sysv/linux/generic/kernel_stat.h
@@ -23,8 +23,9 @@
 /* We provide separate 32-bit API versions that check for EOVERFLOW. */
 #if __WORDSIZE == 64
 # define XSTAT_IS_XSTAT64 1
+#define STATFS_IS_STATFS64 1
 #else
 # define XSTAT_IS_XSTAT64 0
+#define STATFS_IS_STATFS64 0
 #endif

diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
b/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
index 5c10da3356f2..dd970ba69a7c 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h
@@ -18,4 +18,4 @@

 #define STAT_IS_KERNEL_STAT 1
 #define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
+#define STATFS_IS_STATFS64 1

diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
b/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
index b38bf741d37b..ac580001f01b 100644
--- a/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
+++ b/sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h
@@ -18,4 +18,4 @@

 #define STAT_IS_KERNEL_STAT 1
 #define XSTAT_IS_XSTAT64 1
-#define STATFS_IS_STATFS64 0
+#define STATFS_IS_STATFS64 1
---------->8-----------

And at any rate, no architecture for any ABI defines it to 1 today, it all seems
dead code to me.

Thx,
-Vineet


More information about the Libc-alpha mailing list