[PATCHv4 1/2] powerpc64le: refactor e_sqrtf128.c

Paul E Murphy murphyp@linux.ibm.com
Tue Jun 16 19:06:34 GMT 2020



On 6/15/20 8:33 PM, Paul A. Clarke wrote:
> On Mon, Jun 15, 2020 at 03:59:06PM -0500, Paul E. Murphy via Libc-alpha wrote:
>> Combine both implementations into a single file to allow
>> building twice with appropriate multiarch support when possible.
>> Notably, gcc7x does not supporting inlining sqrtf128 via the usual
>> __builtin_sqrtf128,  it arrived in gcc8.
> 
> Not sure you need that last sentence.
> 
>> Likewise, this maintains the existing optimal behavior when
>> building with a power9 or newer cpu.
> 
> You may not need this sentence either. It's pretty clear in the code.

I've removed both, and pushed.  Thank you for your review.


More information about the Libc-alpha mailing list