[PATCH] manual/jobs.texi: remove unused var from example code

Carlos O'Donell carlos@redhat.com
Wed Jun 3 22:16:06 GMT 2020


On 6/3/20 5:07 PM, Florian Weimer wrote:
> * Carlos O'Donell via Libc-alpha:
> 
>> On 5/23/20 3:18 PM, Aurelien Aptel via Libc-alpha wrote:
>>> The do_job_notification() function defines a variable without using
>>> it. Remove it.
>>
>> OK for master.
>>
>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
> Are you going to apply this?

I am.

> If you do, please be careful because due to the mailing list mangling,
> you cannot use “git am”.

Patchwork sees things before mangling, and my workflow takes advantage of that.

# git-pw patch apply 39357;

*AND* for the gold star, it auto-applies my reviewed-by line because patchwork
is tracking them (along with other tags).

commit 74edc05817c126212c826c1a046a9465d0efe287 (HEAD -> master)
Author: Aurélien Aptel <aurelien.aptel@gmail.com>
Date:   Sat May 23 21:18:09 2020 +0200

    manual/jobs.texi: remove unused var from example code
    
    The do_job_notification() function defines a variable without using
    it. Remove it.
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

commit a7a3435c9a0769744c7748f9d95510d0a99be7d1 (origin/master, origin/HEAD)
...

Isn't that nice!

Just built the manual, and verified the pdf looks good.

Commited.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list