[PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

Adhemerval Zanella adhemerval.zanella@linaro.org
Mon Jun 1 18:32:57 GMT 2020

On 01/06/2020 15:12, Vineet Gupta wrote:
> On 6/1/20 7:42 AM, Adhemerval Zanella via Libc-alpha wrote:
>> You will need to move this definitions inside the !USE_SQRTF_BUILTIN
>> to avoid defined by not used warnings.  Current practice is to just
>> open code the constants and let compiler optimize the constant pool:
> Won't it be better to keep the const variable and trust the compiler to subsume it
> instead of open coding in multiple places. Makes it more readable ?

I don't have a strong preference, it is just the recent math optimizations
use the constant directly in the hex format instead of trying to factoring
them out.

More information about the Libc-alpha mailing list