[RFC 00/12] [RFC] y2038: Convert timespec_{sub|add|create} in support to be Y2038 safe
Lukasz Majewski
lukma@denx.de
Mon Jun 1 14:07:28 GMT 2020
This patch set is the first attempt to convert functions utilized by nptl and
pthreads to support 64 bit time.
First timespec* functions are renamed to have common "__" prefix for internal
functions. This is a preparatory work for further conversion.
One question with this patch set is how shall we tackle the conversion
of time related functions (like e.g. ./support/timespec_add) used internally in
glibc as helper functions for internal code or tests.
I could follow the approach used for glibc syscalls (like clock_settime) to have
two versions depending on __TIMESIZE and __WORDSIZE, but this seems to be an
overkill for internally used functions.
Patches with "Convert:" prefix replace struct timespec with struct __timespec64
in timespec_* functions. This is necessary to have in-glibc proper support for
64 bit time.
The problem is with instant replacement of struct timespec with struct
__timespec64 in glibc internal code (and tests).
For replacing timesize with __timesize64 I could:
- Replace its occurences in relevant directories - like ./nptl or
./sysdeps/pthreads
- Replace them in functions (tests) and use explicit conversion functions - like
valid_timespec_to_timespec64()
- Replace _all_ occurences of struct timespec with struct __timespec64 at once
with using sed on glibc tree.
The last option seems to be the most appealing as we already use __timespec64
(with its aliassing) for some core system syscalls (like clock_gettime).
However, such patch shall be applied just after the release of new stable
version to have time for potential fixes.
Lukasz Majewski (12):
doc: Fix wording and formattine in ./support/README
y2038: Rename timespec_compare to __timespec_compare
y2038: Rename make_timespec to __make_timespec
y2038: Rename xclock_gettime to __xclock_gettime
y2038: Rename xclock_now to __xclock_now
y2038: Rename timespec_sub to __timespec_sub
y2038: Rename timespec_add to __timespec_add
y2038: Convert __make_timespec to be Y2038 safe
y2038: Convert __xclock_gettime to be Y2038 safe
y2038: Convert __xclock_now to be Y2038 safe
y2038: Convert timespec* files in ./support to be Y2038 safe
y2038: Convert timespec_* from posix-timer.h to be Y2038 safe
nptl/tst-eintr2.c | 4 ++--
nptl/tst-eintr5.c | 4 ++--
nptl/tst-rwlock6.c | 14 +++++++-------
nptl/tst-rwlock7.c | 10 +++++-----
nptl/tst-rwlock9.c | 10 +++++-----
nptl/tst-sem17.c | 2 +-
nptl/tst-sem5.c | 4 ++--
support/README | 4 ++--
support/timespec-add.c | 12 ++++++------
support/timespec-sub.c | 18 +++++++++---------
support/timespec.c | 12 ++++++------
support/timespec.h | 27 ++++++++++++++-------------
support/xclock_gettime.c | 5 ++---
support/xtime.h | 9 +++++----
sysdeps/mach/clock_nanosleep.c | 4 ++--
sysdeps/pthread/posix-timer.h | 11 ++++++-----
sysdeps/pthread/timer_gettime.c | 4 ++--
sysdeps/pthread/timer_routines.c | 14 +++++++-------
sysdeps/pthread/timer_settime.c | 4 ++--
sysdeps/pthread/tst-cond11.c | 2 +-
sysdeps/pthread/tst-cond26.c | 2 +-
sysdeps/pthread/tst-cond27.c | 4 ++--
sysdeps/pthread/tst-join14.c | 2 +-
sysdeps/pthread/tst-join3.c | 8 ++++----
sysdeps/pthread/tst-join5.c | 12 ++++++------
sysdeps/pthread/tst-mutex5.c | 12 ++++++------
sysdeps/pthread/tst-mutex9.c | 4 ++--
sysdeps/pthread/tst-rwlock14.c | 2 +-
28 files changed, 111 insertions(+), 109 deletions(-)
--
2.20.1
More information about the Libc-alpha
mailing list