[PATCH] Linux: Remove rseq support

Szabolcs Nagy szabolcs.nagy@arm.com
Fri Jul 17 08:59:03 GMT 2020


The 07/17/2020 09:50, Szabolcs Nagy wrote:
> > I can change the magic constant to 168, to reflect that the linker
> > editor did a poor job with the static TLS layout, resulting in
> > unnecessary padding.  I'm checking if this fixes the test on
> > powerpc64le.  But I really think this is a test bug.
> 
> no, that test passed with glibc 2.31 and
> i think it should pass with 2.32 too.

of course this is not true because of
the tls optimization bug i was fixing.

which means on other targets that don't
use optimizations there is extra 512
bytes in the test which happens to be
exactly 32*16 by which you reduced the
available static tls, so other targets
pass the test either way (with or
without reducing LIBC_IE_TLS)

but if i remove that 512byte slack from
the test then it would be visible that
you introduced a regression on all targets.


More information about the Libc-alpha mailing list