[PATCH v2 11/18] RISC-V: Add ABI lists
Alistair Francis
alistair23@gmail.com
Mon Jul 13 16:14:03 GMT 2020
On Sun, Jul 12, 2020 at 1:57 PM Maciej W. Rozycki via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Alistair,
>
> Maybe: "RISC-V: Add 32-bit ABI lists"?
Fixed.
>
> On Wed, 3 Jun 2020, Alistair Francis via Libc-alpha wrote:
>
> > Use the check-api and update-abi to generate the abilist for rv32.
>
> What does `check-api' refer to? I can't see such a Makefile target or a
> script. Also something's missing or extraneous here WRT first "the".
I have corrected this.
>
> > diff --git a/sysdeps/unix/sysv/linux/riscv/c++-types.data b/sysdeps/unix/sysv/linux/riscv/c++-types.data
> > new file mode 100644
> > index 0000000000..0fb0143ae7
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/riscv/c++-types.data
>
> This would better be `sysdeps/unix/sysv/linux/riscv/rv32/c++-types.data',
> I think. We have no "default" architecture. Likewise the other files.
> Let me know if you disagree.
Agreed! I have moved it into the rv32 directory.
>
> Otherwise these are all generated files, and I have verified the contents
> pass our checks, so it all looks good to me.
Thanks!
Alistair
>
> Maciej
More information about the Libc-alpha
mailing list