[PATCH v6 2/3] rtld: Account static TLS surplus for audit modules

Florian Weimer fweimer@redhat.com
Wed Jul 8 14:24:39 GMT 2020


* Szabolcs Nagy:

> diff --git a/manual/tunables.texi b/manual/tunables.texi
> index 089cd30c43..1211f03829 100644
> --- a/manual/tunables.texi
> +++ b/manual/tunables.texi
> @@ -240,13 +240,16 @@ following tunables in the @code{rtld} namespace:
>  @deftp Tunable glibc.rtld.nns
>  Sets the number of supported dynamic link namespaces (see @code{dlmopen}).
>  Currently this limit can be set between 1 and 16 inclusive, the default is 4.
>  Each link namespace consumes some memory in all thread, and thus raising the
>  limit will increase the amount of memory each thread uses. Raising the limit
> -is useful when your application uses more than 4 dynamic linker audit modules
> -e.g. LD_AUDIT, or will use more than 4 dynamic link namespaces as created
> -by @code{dlmopen} with an lmid argument of @code{LM_ID_NEWLM}.
> +is useful when your application uses more than 4 dynamic link namespaces as
> +created by @code{dlmopen} with an lmid argument of @code{LM_ID_NEWLM}.
> +Note: dynamic linker audit modules are loaded in their own dynamic link
> +namespaces, but they are not accounted in glibc.rtld.nns, but implicitly
> +increase the per thread memory usage as necessary, so this tunable does not
> +need to be changed to allow many audit modules e.g. via LD_AUDIT.
>  @end deftp

The “Note:” will land in the middle of the paragraph.  I suggest to drop
it.  glibc.rtld.nns should be in @code.  I suggest to start a new
sentence at “but implicitly“, i.e., “They implicity increase …”.

“per thread” should probably be “per-thread” (attributive use).

LD_AUDIT should be in @env (twice).

Thanks,
Florian



More information about the Libc-alpha mailing list