V2 [PATCH 1/2] Update tunable min/max values

H.J. Lu hjl.tools@gmail.com
Mon Jul 6 13:13:43 GMT 2020


On Mon, Jul 6, 2020 at 5:47 AM Carlos O'Donell <carlos@redhat.com> wrote:
>
> On 7/3/20 7:09 PM, H.J. Lu wrote:
> >> Why not raise the dl-tunables.list minimum to 1?
> >> Then the above code just becomes what we used to have.
> >
> > What we used to have are
> >
> >   cpu_features->non_temporal_threshold
> >     = TUNABLE_GET (x86_non_temporal_threshold, long int, NULL);
> > ...
> >   __x86_shared_non_temporal_threshold
> >     = (cpu_features->non_temporal_threshold != 0
> >        ? cpu_features->non_temporal_threshold
> >        : __x86_shared_cache_size * threads * 3 / 4);
> >
> > I just changed the order.
> This is a bug in sysdeps/x86/dl-tunables.list where we have failed
> to set the minimum to 1. Please fix dl-tunables.list instead of
> rewriting the code which is incorrect?

I will update this patch after 2.32 is branched since it isn't needed for
2.32.


-- 
H.J.


More information about the Libc-alpha mailing list