v2 [PATCH 1/4] nss: Introduce <nss_module.h>

Florian Weimer fweimer@redhat.com
Mon Jul 6 12:03:17 GMT 2020


* DJ Delorie:

> Florian Weimer <fweimer@redhat.com> writes:
>> Do you intend to indicate co-author status for some of these patches
>> when committing them?
>
> Patches 1/4-3/4 have your name on them in git; I only swapped in mine
> for the emails.  My name is on 4/4.  I noted that in the v1 0/4 message.
>
> Hiding this information this way seems to be a side-effect of dropping
> changelogs...

The git tools usually put a From: line in the message boyd in such
cases.

>> I think the intent is to eventually replace the string literals
>> containing function names with enum constants.  Maybe this should be
>> mentioned in one of the commit messages.
>
> Do we typically put forward-planning notes in commit messages?

I think we've already done it in cases where it helps to understand the
change.  It seems important to capture this somewhere.

Thanks,
Florian



More information about the Libc-alpha mailing list