[PATCH v5 04/13] linux: Fix __NSIG_WORDS and add __NSIG_BYTES

[Adhemerval Zanella]

On 02/07/2020 16:08, Carlos O'Donell wrote:
> On 6/19/20 9:43 AM, Adhemerval Zanella wrote:
>> The __NSIG_WORDS value is based on minimum number of words to hold
>> the maximum number of signal supported by the architecture.  Maximum
> 
> s/signal/signals/g

Ack.

> 
>> number of signals non multiple of word is rounded up.
> 
> ^^^ This sentence needs rewriting for clarity in the commit message.

In fact I think this setence is redundant, the first one already states
that __NSIG_WORDS is suffice to represent all the supported signals
and the rounding up should be implicit to obtain it. I removed the
confusing sentence.

>  
>> This patch also adds __NSIG_BYTES, which is the number of bytes
>> required to represent the support number of signals.  It is used on
> 
> s/support/supported/g, s/on/in/g

Ack.

> 
>> syscall which takes a sigset_t.
> 
> s/sycall/syscalls/g

Ack.

> 
> Conceptually I like changes like this which move from hard-coded values
> like foo/8 to more concrete semantics e.g. use a value that represents
> what you want to express (and not the result of some other computation).
>  
>> Checked on x86_64-linux-gnu and i686-linux-gnu.
> 
> OK for master with cleaned up commit message.
> 
> No regressions on x86_64 and i686.
> 
> Tested-by: Carlos O'Donell <carlos@redhat.com>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>