[PATCH v7 02/13] ARC: startup and dynamic linking code
Vineet Gupta
Vineet.Gupta1@synopsys.com
Thu Jul 2 16:14:43 GMT 2020
On 7/2/20 4:12 AM, Adhemerval Zanella via Libc-alpha wrote:
>
>
> On 15/06/2020 17:14, Vineet Gupta via Libc-alpha wrote:
>> Code for C runtime startup and dynamic loading including PLT layout.
>
> LGTM, just a couple of indentations nits below.
>
> Revewied-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>> + case R_ARC_GLOB_DAT:
>> + case R_ARC_JUMP_SLOT:
>> + *reloc_addr = value;
>> + break;
>> + case R_ARC_TLS_DTPMOD:
>
> Indentation seems off here.
Fixed.
>> +/* When we enter this piece of code, the program stack looks like this:
>> + argc argument counter (integer)
>> + argv[0] program name (pointer)
>> + argv[1...N] program args (pointers)
>> + argv[argc-1] end of args (integer)
>> + NULL
>
> Indentation seems off here.
Fixed.
Thx,
-Vineet
More information about the Libc-alpha
mailing list