[PATCH 2/6] y2038: hurd: Provide __clock_settime64 function

[Adhemerval Zanella]

On 20/01/2020 15:08, Lukasz Majewski wrote:
> Hi Adhemerval,
> 
>> On 18/01/2020 04:20, Lukasz Majewski wrote:
>>> For Linux glibc ports the __TIMESIZE == 64 ensures proper aliasing
>>> for __clock_settime64 (to __clock_settime).
>>> When __TIMESIZE != 64 (like ARM32, PPC) the glibc expects separate
>>> definition of the __clock_settime64.
>>>
>>> The HURD port only provides __clock_settime, so this patch adds
>>> __clock_settime64 as a tiny wrapper on it.
>>> ---
>>>  sysdeps/mach/hurd/clock_settime.c | 9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>> diff --git a/sysdeps/mach/hurd/clock_settime.c
>>> b/sysdeps/mach/hurd/clock_settime.c index 2c77bad71a..db1ba860dc
>>> 100644 --- a/sysdeps/mach/hurd/clock_settime.c
>>> +++ b/sysdeps/mach/hurd/clock_settime.c
>>> @@ -53,3 +53,12 @@ versioned_symbol (libc, __clock_settime,
>>> clock_settime, GLIBC_2_17); strong_alias (__clock_settime,
>>> __clock_settime_2); compat_symbol (libc, __clock_settime_2,
>>> clock_settime, GLIBC_2_2); #endif
>>> +
>>> +int
>>> +__clock_settime64 (clockid_t clock_id, const struct __timespec64
>>> *ts64) +{
>>> +  struct timespec ts = valid_timespec64_to_timespec (*ts64);
>>> +
>>> +  return __clock_settime (clock_id, &ts);
>>> +}
>>> +libc_hidden_def (__clock_settime64)
>>>   
>>
>> As for https://sourceware.org/ml/libc-alpha/2020-01/msg00445.html I
>> don't think this patch is really required now.
> 
> I think that it is required to allow using __clock_settime64() calls
> internally in glibc.


Ok, I missed the patch where you adjusted the generic settimeofday.
In any case, I would like to avoid mess with generic implementation
for time64 since I am not sure how/when Hurd will try to fix it and
currently all time64 fixes are compartmentalized on Linux sysdep
folder.

I think it might be add Linux specific version of settimeofday to 
handle the time64 support.