[PATCH 02/13] nptl: Sort routines list in Makefile alphabetically
Florian Weimer
fweimer@redhat.com
Thu Feb 20 07:54:00 GMT 2020
* Adhemerval Zanella:
> On 11/02/2020 08:06, Florian Weimer wrote:
>> This will make it easier to review changes which move implementations
>> from libpthread to libc.
>
> This organization does help a lot not only refactoring, but also new
> files. Maybe we could enforce it from now one, thoughts?
We are using this construct in a few other places. Andreas did not like
the final line with the trailing \ though.
routines += function
would avoid that, but it has quadratic behavior in make, and that could
be actually visible in a few places.
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Thanks for all the reviews.
FlFlorian
More information about the Libc-alpha
mailing list