Consensus on high-level objective of cleanup, refactor or rework patches.

[Carlos O'Donell]

On Fri, Feb 14, 2020 at 4:31 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > Do you have any suggestions for reducing the cost of cleanups or refactoring?
>
> Reviewers should consider carefully exactly what needs reviewing when
> reviewing a particular patch or patch series.  In some cases, especially
> given a good commit message, this may well concentrate on the higher-level
> choices and special cases involved in that particular patch, and on
> architecture- and OS-dependencies, and not the parts of the patch that are
> clearly implementing the mechanical parts of a previously agreed cleanup,
> unless those parts suggest a design issue that needs to be addressed.

Let me reiterate your suggestion then, which is somewhat of an
inversion of my suggestion.

Reviewers, like myself, should consider reviewing *less* when it is
clearly evident that additional review is not required?

I can accept that such a  solution yields a faster turnaround for
patch review, but the latency may still exist, that is that developers
are waiting around for patches to be reviewed.

Cheers,
Carlos.