[PATCH 5/5] posix: Sync fnmatch with gnulib
Paul Eggert
eggert@cs.ucla.edu
Thu Dec 31 21:54:34 GMT 2020
On 12/30/20 12:15 PM, Adhemerval Zanella wrote:
> - ssize_t level;
> + size_t level;
'level' should be ptrdiff_t not ssize_t, for portability to
(now-ancient, but still allowed by POSIX) hosts where ssize_t is 32 bits
and size_t is 64 bits.
> - CHAR str[];
> + CHAR str[FLEXIBLE_ARRAY_MEMBER];
This assumes C99 flex array members which is fine for glibc but dubious
for Gnulib; it should be safer to use __flexarr.
> Because otherwise it triggers some glibc regressions:
Thanks for spotting that. I installed the attached patch into Gnulib,
which should fix the glibc regressions and the other abovementioned
glitches, so that you should now be able to sync fnmatch from Gnulib
unchanged.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fnmatch-merge-from-glibc-proposal.patch
Type: text/x-patch
Size: 3479 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20201231/0bb627b7/attachment.bin>
More information about the Libc-alpha
mailing list