[RFC][PATCH] * bits/confname.h: Define _CS_POSIX_V7_THREADS_CFLAGS, _CS_POSIX_V7_THREADS_LDFLAGS
Siddhesh Poyarekar
siddhesh@gotplt.org
Mon Dec 21 05:26:58 GMT 2020
On 10/27/20 5:03 AM, Érico Nogueira via Libc-alpha wrote:
> From: Érico Rolim <ericonr@disroot.org>
>
> I would like to add these enums in order to conform to the POSIX
> specification: https://www.man7.org/linux/man-pages/man0/unistd.h.0p.html
>
> This change also helps musl-libc, since they want to have these defines
> with the same values as glibc.
>
> I tried to add them for the bits/confname.h and
> conform/data/unistd.h-data files following the example of the other
> values, but didn't know how to plug them into the confstr / __sysconf
> implementations.
It's been a while since I touched this code, but IIRC you need to add
your new variables to posix/posix-conf-vars.list.
That said, could you please let me know if you have a copyright
assignment agreement with the FSF? I suppose this change may be OK
given that it is under 20 lines but one of the stewards could confirm
for sure.
Thanks,
Siddhesh
>
> bits/confname.h | 7 ++++++-
> conform/data/unistd.h-data | 2 ++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/bits/confname.h b/bits/confname.h
> index 5dc8215093..fdc5403697 100644
> --- a/bits/confname.h
> +++ b/bits/confname.h
> @@ -670,6 +670,11 @@ enum
>
> _CS_V6_ENV,
> #define _CS_V6_ENV _CS_V6_ENV
> - _CS_V7_ENV
> + _CS_V7_ENV,
> #define _CS_V7_ENV _CS_V7_ENV
> +
> + _CS_POSIX_V7_THREADS_CFLAGS,
> +#define _CS_POSIX_V7_THREADS_CFLAGS _CS_POSIX_V7_THREADS_CFLAGS
> + _CS_POSIX_V7_THREADS_LDFLAGS
> +#define _CS_POSIX_V7_THREADS_LDFLAGS _CS_POSIX_V7_THREADS_LDFLAGS
> };
> diff --git a/conform/data/unistd.h-data b/conform/data/unistd.h-data
> index aa070528e8..6c4b52a733 100644
> --- a/conform/data/unistd.h-data
> +++ b/conform/data/unistd.h-data
> @@ -367,6 +367,8 @@ constant _CS_POSIX_V7_LP64_OFF64_LIBS
> constant _CS_POSIX_V7_LPBIG_OFFBIG_CFLAGS
> constant _CS_POSIX_V7_LPBIG_OFFBIG_LDFLAGS
> constant _CS_POSIX_V7_LPBIG_OFFBIG_LIBS
> +constant _CS_POSIX_V7_THREADS_CFLAGS
> +constant _CS_POSIX_V7_THREADS_LDFLAGS
> constant _CS_POSIX_V7_WIDTH_RESTRICTED_ENVS
> constant _CS_V7_ENV
> # endif
>
More information about the Libc-alpha
mailing list