[PATCHv2] alpha: Remove anonymous union in struct stat [BZ #27042]

Adhemerval Zanella adhemerval.zanella@linaro.org
Thu Dec 17 19:10:03 GMT 2020



On 17/12/2020 15:18, Matt Turner wrote:
> On Tue, Dec 15, 2020 at 11:56 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * Matt Turner via Libc-alpha:
>>
>>> On Thu, Dec 10, 2020 at 4:18 PM Adhemerval Zanella via Libc-alpha
>>> <libc-alpha@sourceware.org> wrote:
>>>> On 09/12/2020 22:19, Matt Turner via Libc-alpha wrote:
>>>>> This is clever, but it confuses downstream detection in at least zstd
>>>>> and GNOME's glib. zstd has preprocessor tests for the 'st_mtime' macro,
>>>>> which is not provided by the path using the anonymous union; glib checks
>>>>> for the presence of 'st_mtimensec' in struct stat but then tries to
>>>>> access that field in struct statx (which might be a bug on its own).
>>>>> ---
>>>>> The macros affect the definitions in kernel_stat.h, so rename them. Not
>>>>> thrilled.
>>>>
>>>> LGTM, thanks.
>>>>
>>>> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>>>
>>> Thank you. Should we wait for any other input?
>>
>> I think Adhemerval's review is sufficient.  Thanks.
> 
> Thank you both. Could I bother one of you to push the patch?
> 

I will handle it.


More information about the Libc-alpha mailing list