[RFC] Updating patchwork patches on commit
Siddhesh Poyarekar
siddhesh@gotplt.org
Tue Dec 8 02:57:01 GMT 2020
On 12/7/20 11:41 PM, Joseph Myers wrote:
> On Mon, 7 Dec 2020, DJ Delorie via Libc-alpha wrote:
>
>> Siddhesh Poyarekar <siddhesh@gotplt.org> writes:
>>> Well your NSS patches did match and auto-close; in fact the v4 of 3/6 in
>>> that patchset also got closed as Committed because diff-wise it was
>>> identical to v5 3/6 :)
>>
>> Ah, patchwork hash != git hash. Nevermind ;-)
>
> A previous discussion suggested "git patch-id" was appropriate to use for
> this purpose, but I don't know if it's what patchwork actually uses.
>
It doesn't; it has it's own hashing function where it normalizes spaces
and newline chars to avoid false negatives. It could however do with
some rudimentary sorting of diff lines to ensure that it generates the
same hash for reordered diffs. I'll play with that a bit later in the
week and see if it improves matching.
Siddhesh
More information about the Libc-alpha
mailing list