[RFC] Updating patchwork patches on commit

Siddhesh Poyarekar siddhesh@gotplt.org
Mon Dec 7 16:39:39 GMT 2020


On 12/7/20 9:45 PM, DJ Delorie wrote:
> Siddhesh Poyarekar <siddhesh@gotplt.org> writes:
>> This means that diffs of 14 patches were modified before committing.
> 
> Do you try removing the Reviewed-by tags and re-hashing?  My last step
> before committing is usually to add those according to the reviews, so
> my patches might never match patchwork.
> 

Well your NSS patches did match and auto-close; in fact the v4 of 3/6 in 
that patchset also got closed as Committed because diff-wise it was 
identical to v5 3/6 :)

Patchwork stores the diff separately and the hash is generated only on 
the diff using the patchwork hasher in patchwork/hasher.py.  So changing 
the commit message in any way does not change the hash.

Siddhesh


More information about the Libc-alpha mailing list