[PATCH 3/3] mips: remove register spill
Adhemerval Zanella
adhemerval.zanella@linaro.org
Fri Dec 4 12:33:21 GMT 2020
On 04/12/2020 08:03, Maciej W. Rozycki wrote:
> On Tue, 1 Dec 2020, Adhemerval Zanella via Libc-alpha wrote:
>
>>> I would like to combine the Patch 2/3 and Patch 3/3 into one patch,
>>> since Patch 2/3 only fix sp alignment, but the key point is folllowing syscall
>>> restart convention, any advice?
>>
>> Send a v2 with the patches merged and the hp-inline fix.
>
> I would defer the removal of the old syscall restart convention in this
> single place only. I don't think we need to introduce such a mess.
>
> Instead an audit should be made and all the places adjusted with a single
> change. That would include at least MIPS16 wrappers, and IIRC some
> microMIPS support code, and then the comment I referred previously needs
> to be adjusted accordingly (maybe removed altogether even).
>
> Maciej
Alright, it seems better indeed.
More information about the Libc-alpha
mailing list