[PATCH] sunrpc: use snprintf to guard against buffer overflow

Florian Weimer fweimer@redhat.com
Thu Dec 3 10:19:46 GMT 2020


* Philipp Tomsich:

>> The switch to snprintf is reasonable (with the caveat that this code is
>> in very, very deep maintenance mode), but I think you should replace the
>> strlen check and also check for negative i.
>
> I'll provide a V2.

Looking forward to it.  You can probably expand the definition of OPSYS
and remove the now-unused macros, too.

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill



More information about the Libc-alpha mailing list