[PATCH] C11 threads: Fix inaccuracies in testsuite

[Corinna Vinschen]

On Aug 31 12:16, Florian Weimer wrote:
> * Corinna Vinschen:
> 
> > On Aug 31 10:59, Florian Weimer wrote:
> >> * Corinna Vinschen via Libc-alpha:
> >> 
> >> > - tst-mtx-recursive.c: mtx_init fails to use mtx_plain.  Per C11
> >> >   specs, using mtx_recursive alone is not supported.  This isn't
> >> >   catched because mtx_plain is defined as 0.
> >> >
> >> > - tst-thrd-sleep.c: thrd_sleep() returns 0 on success, a negative
> >> >   value on failure.  Testing against thrd_success is incorrect.
> >> >
> >> > - tst-tss-basic.c: tss_set() is incorrectly checkd for a non-0
> >> >   value.  The test should test aginst C11 threads error codes.
> >> >   This isn't catched because thrd_success is defined as 0.
> >> >
> >> > Note that all three tests fail on FreeBSD, which defines all mutex type
> >> > values, as well as all C11 threads error codes with non-0 values.
> >> 
> >> The patch looks good to me.  Is this correctly described in the glibc
> >> manual?  I have checked, and I think the manual is correct, but it would
> >> be nice if you could double-check it.
> >
> > Checked.  The manual describes the parameters and return values
> > correctly.
> 
> Thanks.
> 
> >> > Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
> >> 
> >> I assume this is covered by the Red Hat copyright assignment?
> >
> > I don't know, I assumed this.
> 
> It will be, unless you have made special arrangements with Red Hat about
> who owns copyright in the works you create for Red Hat.

I didn't make any special arrangements, so this should be ok.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat