[PATCH] x32: Add <fixup-asm-unistd.h> and regenerate arch-syscall.h

[H.J. Lu]

On Wed, Aug 26, 2020 at 2:35 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/Makefile b/sysdeps/unix/sysv/linux/x86_64/x32/Makefile
> > index 16b768d8ba..2cd35c120b 100644
> > --- a/sysdeps/unix/sysv/linux/x86_64/x32/Makefile
> > +++ b/sysdeps/unix/sysv/linux/x86_64/x32/Makefile
> > @@ -3,6 +3,8 @@ default-abi := x32
> >
> >  ifeq ($(subdir),misc)
> >  sysdep_routines += arch_prctl
> > +
> > +tests-internal += tst-set_thread_area
> >  endif
>
> I do not think the test is valuable.  I just added it to show that
> things do actually compile with older Linux headers because you didn't
> believe me. 8-)

Removed.

> > diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/fixup-asm-unistd.h b/sysdeps/unix/sysv/linux/x86_64/x32/fixup-asm-unistd.h
> > new file mode 100644
> > index 0000000000..01d1f448ca
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/x86_64/x32/fixup-asm-unistd.h
>
> > +/* X32 uses the same 64-bit syscall interface for set_thread_area.   */
> > +#ifndef __NR_set_thread_area
> > +# define __NR_set_thread_area 1073742029
> > +#endif
>
> I think the comment should reference the Linux version in which the
> missing system call was fixed.
>

Given that set_thread_area isn't for user application, I don't know when
my fix will be merged into the upstream kernel.

Here is the updated patch.   OK for master?

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x32-Add-fixup-asm-unistd.h-and-regenerate-arch-sysca.patch
Type: text/x-patch
Size: 2794 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20200827/35883d04/attachment.bin>