[PATCH 1/4] Sync getcwd with gnulib

Adhemerval Zanella adhemerval.zanella@linaro.org
Thu Aug 27 11:33:28 GMT 2020



On 27/08/2020 08:10, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> On Thu, Aug 27, 2020 at 7:58 AM Florian Weimer <fweimer@redhat.com> wrote:
>>>
>>> * Adhemerval Zanella:
>>>
>>>> This specific part is not used by glibc, for LIBC my patch sets
>>>> HAVE_MINIMALLY_WORKING_GETCWD
>>>> explicit to 0. I just added to sync with gnulib implementation and
>>>> make future changes less complex
>>>> (and it also checks if gnulib code to disable the LIBC part is working
>>>> correctly).
>>>
>>> I meant: Is anything of this used on Hurd at all?  I don't think so.
>>
>> No, Hurd re implements getcwd.c.  I personally would prefer to get
>> streamline version without all the clutter required to build on all
>> the platforms gnulib support, but my impression from other gnulib code
>> sync was that we should avoid it.
> 
> Hmm.  Maybe I will give this a try and see how much code is left after
> the cleanup.  This shouldn't block the current sync if you want to go
> ahead with it.

The io/getcwd-system.os text size from the last patch in this set is 1439
on x86_64.  I think resulting size reduction possible on ld.so would 
something like that.


More information about the Libc-alpha mailing list