[PATCH] [RFC] y2038: nptl: Convert pthread_cond_{clock|timed}wait to support 64 bit time

Florian Weimer fweimer@redhat.com
Wed Aug 26 18:06:00 GMT 2020


* Lukasz Majewski:

>> Some comments below.  As a general comment, I think you are using 8
>> whitespace instead of tab.
>
> Yes, correct. I've already enabled the "gnu" coding style
> (c-set-style) in emacs. It automatically replaces some spaces with tabs.
>
> However, with some earlier patches - such approach was not accepted and
> using 2 spaces for indentation like:
>
> if (foo)
>   {
>     if (baz)
>       flag = 1;
>
>   }

For new files, I prefer using spaces instead of tabs because the diffs
show the correct indentation.  With tabs, they sometimes do not because
the leading  /+/- does not shift a following tab one column right
(like it would do for eight spaces).

Thanks,
Florian



More information about the Libc-alpha mailing list