[PATCH v5 00/17] glibc port for 32-bit RISC-V (RV32)

Maciej W. Rozycki macro@wdc.com
Wed Aug 26 16:06:53 GMT 2020


On Tue, 25 Aug 2020, Alistair Francis wrote:

> > > io/tst-lockf.out
> > > error: subprocess failed: lockf
> > > error:   unexpected output from subprocess
> > > tst-lockf.c:49: numeric comparison failure
> > >    left: 0 (0x0); from: lockf (temp_fd, F_TEST, 1024)
> > >   right: -1 (0xffffffff); from: -1
> > > error: 2 test failures
> >
> >  This might be more interesting to look into further; as `len' is of the
> > `off_t' type it would be good to double-check it is correctly handled.
> 
> I have fixed this as well, the test is incorrectly calling the lockf()
> function (not 64-bit version). I'll send a patch.

 Shouldn't `lockf' and `lockf64' be aliases to each other on RV32?  IOW do 
we support a non-LFS environment at all?

 (Of course the test case may still require an adjustment as it seems to 
imply non-LFS support to be present, i.e.:

  /* Check if non-LFS interface cap access to 32-bif off_t.  */
  TEST_COMPARE (lseek64 (temp_fd, (off64_t)INT32_MAX, SEEK_SET),
		(off64_t)INT32_MAX);

though I find it odd as 64-bit targets starting from DEC Alpha have never 
had it.)

  Maciej


More information about the Libc-alpha mailing list